Looks good. A few comments.
http://codereview.chromium.org/42006/diff/1/3
File src/codegen-ia32.cc (right):
http://codereview.chromium.org/42006/diff/1/3#newcode686
Line 686: // should be inlined, placed in the stub, or omitted entirely.
To parallel the order of the enum, "should be placed in
LGTM when Kevin's comments are addressed plus some more comments.
Also what is the impact on compilation time and benchmark scores on top
of the code bloat question in the comments?
Thanks,
-Ivan
http://codereview.chromium.org/42006/diff/1/3
File src/codegen-ia32.cc (right):
http://coderevi
The size of compiled code does not seem to change much on the V8
benchmarks, and compilation time does not seem to change on Parsy.
http://codereview.chromium.org/42006/diff/1/3
File src/codegen-ia32.cc (right):
http://codereview.chromium.org/42006/diff/1/3#newcode686
Line 686: // should be inl
These changes finally made, and submitted in changelist 51007.
http://codereview.chromium.org/51007/show
http://codereview.chromium.org/42006/diff/1/3
File src/codegen-ia32.cc (right):
http://codereview.chromium.org/42006/diff/1/3#newcode686
Line 686: // should be inlined, placed in the stub, o
