Hi Andrey,
I'm actually considering rejecting this CL. It just seems to much of a hack
to me. But I still want to take a second look at check whether we can
salvage it somehow, or maybe I can find a better solution to the issue
shown in the regression test.
Regards,
Yang
On Wed, Sep 25, 2013
Yang, could you plz take a look?
https://codereview.chromium.org/22801003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and st
https://codereview.chromium.org/22801003/diff/2001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/22801003/diff/2001/src/ia32/code-stubs-ia32.cc#newcode4877
src/ia32/code-stubs-ia32.cc:4877: __ cmp(ebp, edx);
On 2013/09/13 09:47:56, Yang wro
My question here is: by skipping the try-catch handler, where is that
pending
exception handled? I don't see it being cleared anywhere. So even though
we
restarted the frame, the old exception is still pending?
I guess the following code always takes care of pending exception variable:
//
On 2013/09/13 09:47:56, Yang wrote:
I'm not entirely familiar with how frame restart works, so let me try to
understand:
When we restart frames, we find the ones we want to restart, clear the
corresponding range on the stack, and replace it with the frame dropper
builtin,
which calls the fun
I'm not entirely familiar with how frame restart works, so let me try to
understand:
When we restart frames, we find the ones we want to restart, clear the
corresponding range on the stack, and replace it with the frame dropper
builtin,
which calls the function to the bottom frame again for re
ping
https://codereview.chromium.org/22801003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
