[v8-dev] Re: Print and save JS stacktrace on OOM crash. (issue 1149623010 by u...@chromium.org)

2015-06-05 Thread ulan
Thank, addressed comments. Landing. https://codereview.chromium.org/1149623010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group

[v8-dev] Re: Print and save JS stacktrace on OOM crash. (issue 1149623010 by u...@chromium.org)

2015-06-05 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149623010/20001 https://codereview.chromium.org/1149623010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Print and save JS stacktrace on OOM crash. (issue 1149623010 by u...@chromium.org)

2015-06-05 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/25981994b781624518540e9fc28c09a40d635245 Cr-Commit-Position: refs/heads/master@{#28818} https://codereview.chromium.org/1149623010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Print and save JS stacktrace on OOM crash. (issue 1149623010 by u...@chromium.org)

2015-06-05 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1149623010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Print and save JS stacktrace on OOM crash. (issue 1149623010 by u...@chromium.org)

2015-06-05 Thread jochen
lgtm with nits https://codereview.chromium.org/1149623010/diff/1/src/string-stream.h File src/string-stream.h (right): https://codereview.chromium.org/1149623010/diff/1/src/string-stream.h#newcode42 src/string-stream.h:42: ~FixedStringAllocator() {} override