https://codereview.chromium.org/99573002/diff/90001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/90001/src/promise.js#newcode65
src/promise.js:65: if (!%_IsConstructCall()) throw
MakeTypeError('not_a_promise', [this]);
On 2014/01/09 16:09:56, rossberg
https://codereview.chromium.org/99573002/diff/90001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/90001/src/promise.js#newcode65
src/promise.js:65: if (!%_IsConstructCall()) throw
MakeTypeError('not_a_promise', [this]);
On 2014/01/09 15:47:15, arv wrot
https://codereview.chromium.org/99573002/diff/90001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/90001/src/promise.js#newcode65
src/promise.js:65: if (!%_IsConstructCall()) throw
MakeTypeError('not_a_promise', [this]);
Doesn't this break sub classing?
Committed patchset #4 manually as r18515 (presubmit successful).
https://codereview.chromium.org/99573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
https://codereview.chromium.org/99573002/diff/20001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/20001/src/promise.js#newcode63
src/promise.js:63: function Promise(resolver) {
On 2013/12/11 04:46:31, yhirano wrote:
On 2013/12/10 10:11:15, rossberg wr
https://codereview.chromium.org/99573002/diff/20001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/20001/src/promise.js#newcode63
src/promise.js:63: function Promise(resolver) {
On 2013/12/10 10:11:15, rossberg wrote:
On 2013/12/09 02:31:36, yhirano wr
I didn't see any discussion regarding the race/one function name.
https://codereview.chromium.org/99573002/diff/20001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/20001/src/promise.js#newcode303
src/promise.js:303: "one", PromiseOne,
This should be
https://codereview.chromium.org/99573002/diff/20001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/20001/src/promise.js#newcode63
src/promise.js:63: function Promise(resolver) {
On 2013/12/09 02:31:36, yhirano wrote:
I'm still not sure.
The spec has no
https://codereview.chromium.org/99573002/diff/20001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/20001/src/promise.js#newcode63
src/promise.js:63: function Promise(resolver) {
I'm still not sure.
The spec has not been changed at this point, has it?
h
lgtm
https://codereview.chromium.org/99573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/99573002/diff/1/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/1/src/promise.js#newcode230
src/promise.js:230: typeof (then = x.then) === 'function') {
On 2013/12/04 09:24:43, Dmitry Lomov (chromium) wrote:
Can we not ha
Mostly stylistic comments + objection to shipping deref/relying on defer in
tests that might be addressed in a separate CL
https://codereview.chromium.org/99573002/diff/1/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/99573002/diff/1/src/promise.js#newcode230
src/pr
12 matches
Mail list logo
