Committed patchset #5 manually as r16515 (presubmit successful).
https://codereview.chromium.org/23182003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM.
https://codereview.chromium.org/23182003/diff/27001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/23182003/diff/27001/src/factory.cc#newcode1536
src/factory.cc:1536: Handle accessor(value, isolate());
nit: This can be simplified to just ...
Handle accessor(A
https://codereview.chromium.org/23182003/diff/12001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23182003/diff/12001/src/objects.cc#newcode3135
src/objects.cc:3135: static bool InsertUnique(Name* key,
On 2013/08/26 07:20:24, Sven Panne wrote:
Splitting InsertUniqu
Next round of comments. BTW: I'm not sure if "make grokdump" is needed to
update
tools/v8heapconst.py.
https://codereview.chromium.org/23182003/diff/12001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23182003/diff/12001/src/objects.cc#newcode3135
src/objects.cc:
okay, this is ready for a look
I've used the excessive SetNativeDataProperty name, but there's a chance we
can
remove this entirely in the future...
https://chromiumcodereview.appspot.com/23182003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Y
On 2013/08/21 10:01:53, Sven Panne wrote:
On 2013/08/20 17:05:40, Michael Starzinger wrote:
> [...]
> - SetDataProperty(), for normal data properties taking HValue
> - SetNativeProperty(), for data properties using
Accessor[G/S]etterCallback
> - SetAccessorProperty(), for JavaScript accessors
On 2013/08/20 17:05:40, Michael Starzinger wrote:
[...]
- SetDataProperty(), for normal data properties taking HValue
- SetNativeProperty(), for data properties using
Accessor[G/S]etterCallback
- SetAccessorProperty(), for JavaScript accessors
I would prefer having "Data" somehow in the 2nd
First comment about the API names. Looping in Andreas and Sven about the
naming.
https://codereview.chromium.org/23182003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/23182003/diff/1/include/v8.h#newcode3008
include/v8.h:3008: void SetNativeAccessor(Handle na
