[v8-dev] Re: Reenable d8 stats timers, using the histogram mechanism

2009-04-13 Thread iposva
LGTM -ip http://codereview.chromium.org/67100 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Re: Reenable d8 stats timers, using the histogram mechanism

2009-04-13 Thread davemoore
http://codereview.chromium.org/67100/diff/1/2 File src/d8.cc (right): http://codereview.chromium.org/67100/diff/1/2#newcode329 Line 329: Counter* counter = counter_map_->Lookup(name); On 2009/04/13 23:09:15, iposva wrote: > I know it should not happen, but you should assert that the counter you

[v8-dev] Re: Reenable d8 stats timers, using the histogram mechanism

2009-04-13 Thread iposva
First set of comments. -Ivan http://codereview.chromium.org/67100/diff/1/2 File src/d8.cc (right): http://codereview.chromium.org/67100/diff/1/2#newcode329 Line 329: Counter* counter = counter_map_->Lookup(name); I know it should not happen, but you should assert that the counter you found ma