[v8-dev] Re: Refactored the recording of source position in the generated code. The code g...

2008-12-17 Thread Søren Gjesse
It should be very easy. Both assemblers have the function WriteRecordedPositions, which emits the current position information into the relocation information provided it did not change from when WriteRecordedPositions was called the last time. On Intel WriteRecordedPositions is called when a call

[v8-dev] Re: Refactored the recording of source position in the generated code. The code g...

2008-12-17 Thread iposva
How much work would be involved in having ARM and IA32 assemblers match when relocation info is generated? -Ivan http://codereview.chromium.org/14170/diff/1/9 File src/assembler-ia32.cc (right): http://codereview.chromium.org/14170/diff/1/9#newcode1993 Line 1993: ASSERT(pos != RelocInfo::kNoPos

[v8-dev] Re: Refactored the recording of source position in the generated code. The code g...

2008-12-17 Thread sgjesse
http://codereview.chromium.org/14170/diff/1/9 File src/assembler-ia32.cc (right): http://codereview.chromium.org/14170/diff/1/9#newcode1993 Line 1993: ASSERT(pos != RelocInfo::kNoPosition); On 2008/12/17 07:45:35, Mads Ager wrote: > In the ARM code, RecordPosition and RecordStatementPosition cal

[v8-dev] Re: Refactored the recording of source position in the generated code. The code g...

2008-12-16 Thread ager
LGTM http://codereview.chromium.org/14170/diff/1/9 File src/assembler-ia32.cc (right): http://codereview.chromium.org/14170/diff/1/9#newcode1993 Line 1993: ASSERT(pos != RelocInfo::kNoPosition); In the ARM code, RecordPosition and RecordStatementPosition called WriteRecordedPositions. Why is t