[v8-dev] Re: Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1254723004 by bmeu...@chromium.org)

2015-07-29 Thread jkummerow
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1260423002/ by jkumme...@chromium.org. The reason for reverting is: Suspected to cause Canary crashes. https://codereview.chromium.org/1254723004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://

[v8-dev] Re: Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1254723004 by bmeu...@chromium.org)

2015-07-24 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/440ae014e56924b52337c3747221b79283f07b81 Cr-Commit-Position: refs/heads/master@{#29849} https://codereview.chromium.org/1254723004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1254723004 by bmeu...@chromium.org)

2015-07-24 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1254723004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1254723004 by bmeu...@chromium.org)

2015-07-24 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254723004/1 https://codereview.chromium.org/1254723004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1254723004 by bmeu...@chromium.org)

2015-07-24 Thread ishell
On 2015/07/24 08:45:21, Benedikt Meurer wrote: Hey MIPS people, Can you look into the failures? As far as I can tell, we need at least diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc index 272feda..352289a 100644 --- a/src/mips/code-stubs-mips.cc +++ b/src/mips/code-s

[v8-dev] Re: Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1254723004 by bmeu...@chromium.org)

2015-07-24 Thread bmeurer
Hey MIPS people, Can you look into the failures? As far as I can tell, we need at least diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc index 272feda..352289a 100644 --- a/src/mips/code-stubs-mips.cc +++ b/src/mips/code-stubs-mips.cc @@ -5298,8 +5298,7 @@ void LoadGlobal

[v8-dev] Re: Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1254723004 by bmeu...@chromium.org)

2015-07-24 Thread ishell
lgtm https://codereview.chromium.org/1254723004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Reland^2 "Enable loads and stores to global vars through property cell shortcuts installed into par… (issue 1254723004 by bmeu...@chromium.org)

2015-07-24 Thread bmeurer
Hey Igor, Let's turn on the flag again. :-) Please take a look. Thanks, Benedikt https://codereview.chromium.org/1254723004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v