[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #5 (id:80001) https://codereview.chromium.org/1311993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 5 (id:??) landed as https://crrev.com/69bb3e1f1fcf449c95619d9dd1baa883c7cb51ad Cr-Commit-Position: refs/heads/master@{#30569} https://codereview.chromium.org/1311993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1311993003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1311993003/80001 https://codereview.chromium.org/1311993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread ulan via v8-dev
Thanks! https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h#newcode843 src/heap/heap.h:843: void FinalizeIncrementalMarkingIfComplete(const char* comment); On 2015/09/03 15:01:4

[v8-dev] Re: Reland "Make sure that memory reducer makes progress in incremental marking"" (issue 1311993003 by u...@chromium.org)

2015-09-03 Thread mlippautz
lgtm, thanks for fixing this immediately :) https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1311993003/diff/60001/src/heap/heap.h#newcode843 src/heap/heap.h:843: void FinalizeIncrementalMarkingIfComplete(const c