[v8-dev] Re: Remove calls to non-handlified version of GetProperty(name). (issue 229973004)

2014-04-09 Thread yangguo
Committed patchset #2 manually as r20611 (presubmit successful). https://codereview.chromium.org/229973004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Remove calls to non-handlified version of GetProperty(name). (issue 229973004)

2014-04-09 Thread yangguo
https://codereview.chromium.org/229973004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/229973004/diff/1/src/runtime.cc#newcode9352 src/runtime.cc:9352: isolate, value, MakePair(Failure::Exception(), NULL)); On 2014/04/09 09:52:33, Igor Sheludko wrote: Is it

[v8-dev] Re: Remove calls to non-handlified version of GetProperty(name). (issue 229973004)

2014-04-09 Thread ishell
lgtm with nits: https://codereview.chromium.org/229973004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/229973004/diff/1/src/runtime.cc#newcode9352 src/runtime.cc:9352: isolate, value, MakePair(Failure::Exception(), NULL)); Is it OK to return NULL instead of