[v8-dev] Re: Remove const from BitCast (issue3130033)

2010-08-19 Thread ager
LGTM http://codereview.chromium.org/3130033/diff/5001/6001 File src/utils.h (right): http://codereview.chromium.org/3130033/diff/5001/6001#newcode743 src/utils.h:743: inline Dest BitCast(Source* & source) { The linter will probably complaint about this because we are using a non-const reference

[v8-dev] Re: Remove const from BitCast (issue3130033)

2010-08-19 Thread coldredlemur
done http://codereview.chromium.org/3130033/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Remove const from BitCast (issue3130033)

2010-08-18 Thread kasperl
DBC: http://codereview.chromium.org/3130033/diff/1/2 File src/utils.h (right): http://codereview.chromium.org/3130033/diff/1/2#newcode744 src/utils.h:744: return BitCast(reinterpret_cast(source)); Nit: Indentation is off here. Should be 2 spaces not 4. http://codereview.chromium.org/3130033/sh