[v8-dev] Re: Remove unnecessary overflow check in BuildCreateAllocationMemento. (issue 104313003)

2013-12-04 Thread mvstanton
Committed patchset #2 manually as r18255. https://codereview.chromium.org/104313003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gr

[v8-dev] Re: Remove unnecessary overflow check in BuildCreateAllocationMemento. (issue 104313003)

2013-12-04 Thread dslomov
sheriff's notice: ok to land https://codereview.chromium.org/104313003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Remove unnecessary overflow check in BuildCreateAllocationMemento. (issue 104313003)

2013-12-04 Thread hpayer
LGTM, just make the comment more precise https://codereview.chromium.org/104313003/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/104313003/diff/1/src/hydrogen.cc#newcode2595 src/hydrogen.cc:2595: // This smi value is reset to zero after every gc, overflow

[v8-dev] Re: Remove unnecessary overflow check in BuildCreateAllocationMemento. (issue 104313003)

2013-12-04 Thread bmeurer
LGTM, go ahead! :-) https://codereview.chromium.org/104313003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving