[v8-dev] Re: Removed some work from array-splice

2009-02-02 Thread Erik Corry
On Mon, Feb 2, 2009 at 5:31 PM, wrote: > Reviewers: Erik Corry, > > Description: > Turned down the amount of work done by array-splice to ensure that it > doesn't time out on our slowest platforms. It turns out that almost > all the time was spent in Array.prototype.unshift on a non-array with

[v8-dev] Re: Removed some work from array-splice

2009-02-02 Thread Christian Plesner Hansen
75% of the time was taken up by the 3-4 unshift calls on the 4-large non-array and looking at the implementation it's obvious why that is. On Mon, Feb 2, 2009 at 8:06 PM, Erik Corry wrote: > On Mon, Feb 2, 2009 at 5:31 PM, wrote: >> Reviewers: Erik Corry, >> >> Description: >> Turned down

[v8-dev] Re: Removed some work from array-splice

2009-02-02 Thread Erik Corry
On Mon, Feb 2, 2009 at 8:19 PM, Christian Plesner Hansen wrote: > > 75% of the time was taken up by the 3-4 unshift calls on the > 4-large non-array and looking at the implementation it's obvious > why that is. Ah yes, I'd forgotten that the largest size doesn't get run on non-arrays because