Committed patchset #4 manually as r18275 (presubmit successful).
https://codereview.chromium.org/101763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2013/12/05 08:11:23, Sven Panne wrote:
LGTM. Ooops, forgot that there was only a non-OWNER LGTM :-}
Thank you!
https://codereview.chromium.org/101763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are s
LGTM. Ooops, forgot that there was only a non-OWNER LGTM :-}
https://codereview.chromium.org/101763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsub
On 2013/12/05 07:38:12, Sven Panne wrote:
On 2013/12/05 07:15:22, yurys wrote:
> Sven, I've made the destructor protected, do you have any other
concerns?
I think it is OK, moving to std::unique_ptr might still take a few
years...
:-}
Could you provide OWNER's approval then ? :-)
https:/
On 2013/12/05 07:15:22, yurys wrote:
Sven, I've made the destructor protected, do you have any other concerns?
I think it is OK, moving to std::unique_ptr might still take a few
years... :-}
https://codereview.chromium.org/101763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http:/
On 2013/12/05 07:15:22, yurys wrote:
Sven, I've made the destructor protected, do you have any other concerns?
I think it is OK, moving to std::unique_ptr might still take a few
years... :-}
https://codereview.chromium.org/101763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http:/
Sven, I've made the destructor protected, do you have any other concerns?
https://codereview.chromium.org/101763003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gro
On 2013/12/04 08:07:47, jochen wrote:
we can't use std::unique_ptr because it's not available on mac os 10.6's
libstdc++
Using get() however is inline with the std::unique_ptr API so I think
this is
a
good change.
scoped_ptr doesn't depend on unique_ptr while provides similar interface
On 2013/12/04 07:44:47, alph wrote:
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h
File src/smart-pointers.h (right):
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h#newcode54
src/smart-pointers.h:54: ~SmartPointerBase() { if (p_)
Deallocator::Del
we can't use std::unique_ptr because it's not available on mac os 10.6's
libstdc++
Using get() however is inline with the std::unique_ptr API so I think this
is a
good change.
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h
File src/smart-pointers.h (right):
https://co
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h
File src/smart-pointers.h (right):
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h#newcode54
src/smart-pointers.h:54: ~SmartPointerBase() { if (p_)
Deallocator::Delete(p_); }
On 2013/12/04 07:34:01, yurys
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h
File src/smart-pointers.h (right):
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h#newcode54
src/smart-pointers.h:54: ~SmartPointerBase() { if (p_)
Deallocator::Delete(p_); }
On 2013/12/04 07:34:01, yurys
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h
File src/smart-pointers.h (right):
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h#newcode54
src/smart-pointers.h:54: ~SmartPointerBase() { if (p_)
Deallocator::Delete(p_); }
On 2013/12/03 16:17:55, svenp
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h
File src/smart-pointers.h (right):
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h#newcode54
src/smart-pointers.h:54: ~SmartPointerBase() { if (p_)
Deallocator::Delete(p_); }
Hmmm, this has been like that
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h
File src/smart-pointers.h (right):
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h#newcode87
src/smart-pointers.h:87: ASSERT(p_ == NULL || p_ != new_value);
On 2013/12/03 14:15:03, alph wrote:
maybe: if
lgtm
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h
File src/smart-pointers.h (right):
https://codereview.chromium.org/101763003/diff/1/src/smart-pointers.h#newcode87
src/smart-pointers.h:87: ASSERT(p_ == NULL || p_ != new_value);
maybe: if (p_ == new_value) return;
ht
16 matches
Mail list logo
