[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

A revert of this CL (patchset #17 id:320001) has been created in https://codereview.chromium.org/1226703002/ by machenb...@chromium.org. The reason for reverting is: [Sheriff] Looks like it blocks the roll (bisected). Speculative revert. https://codereview.chromium.org/1210293003/. https://co

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

Committed patchset #17 (id:320001) https://codereview.chromium.org/1218863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group an

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

Patchset 17 (id:??) landed as https://crrev.com/0ecd9e1bd2c6b519d4e7285f46cb7e844bc2235c Cr-Commit-Position: refs/heads/master@{#29451} https://codereview.chromium.org/1218863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messa

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218863002/320001 https://codereview.chromium.org/1218863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subsc

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

I removed the scavenge event, since the check for allocation throughput should subsume it. I also remove the check for high fragmentation to keep it simple for now. https://codereview.chromium.org/1218863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/5706) https://codereview.chromium.org/1218863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/grou

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218863002/260001 https://codereview.chromium.org/1218863002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subsc

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

Thanks! https://codereview.chromium.org/1218863002/diff/240001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1218863002/diff/240001/BUILD.gn#newcode832 BUILD.gn:832: "src/heap/memory-reducer.cc", On 2015/07/02 13:19:06, Hannes Payer wrote: alphabetic order Done. https://co

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

LGTM, if memory and latency did not regression. Super nice cleanup! Just a few nits left. https://codereview.chromium.org/1218863002/diff/240001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/1218863002/diff/240001/BUILD.gn#newcode832 BUILD.gn:832: "src/heap/memory-reducer.cc

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

Thanks. Uploaded new PS. https://codereview.chromium.org/1218863002/diff/180001/src/heap/cleanup-gc.cc File src/heap/cleanup-gc.cc (right): https://codereview.chromium.org/1218863002/diff/180001/src/heap/cleanup-gc.cc#newcode132 src/heap/cleanup-gc.cc:132: void CleanupGC::ScheduleTimer(double d

[v8-dev] Re: Replace reduce-memory mode in idle notification with delayed clean-up GC. (issue 1218863002 by u...@chromium.org)

First round. Really nice cleanup, already looking good. Just a few minor comments (so far). https://codereview.chromium.org/1218863002/diff/180001/src/heap/cleanup-gc.cc File src/heap/cleanup-gc.cc (right): https://codereview.chromium.org/1218863002/diff/180001/src/heap/cleanup-gc.cc#newcode132