[v8-dev] Re: Revert of Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" (issue 1254723005 by machenb...@chromium.org)

2015-07-24 Thread littledan
On 2015/07/24 18:17:00, Dan Ehrenberg wrote: Are you sure you chose this patch correctly? When I run the failing test locally, including the patch that you reverted, it passes. Oh, sorry, following those precise instructions that Yang mailed, I can reproduce the error. And the rollback fixes it

[v8-dev] Re: Revert of Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" (issue 1254723005 by machenb...@chromium.org)

2015-07-24 Thread littledan
Are you sure you chose this patch correctly? When I run the failing test locally, including the patch that you reverted, it passes. https://codereview.chromium.org/1254723005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message b

[v8-dev] Re: Revert of Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" (issue 1254723005 by machenb...@chromium.org)

2015-07-24 Thread machenbach
Repro instructions: git checkout 477d651 gclient sync --nohooks GYP_GENERATORS=ninja GYP_DEFINES="target_arch=x64 v8_target_arch=x64 use_goma=1 embed_script=/path/to/v8/test/mjsunit/mjsunit.js v8_enable_slow_dchecks=1 v8_optimized_debug=1" gclient runhooks ninja -j1000 -C out/Debug d8 out/Debug

[v8-dev] Re: Revert of Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" (issue 1254723005 by machenb...@chromium.org)

2015-07-24 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1254723005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" (issue 1254723005 by machenb...@chromium.org)

2015-07-24 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/7d02830e7436d23cb00e1d39ea0347fb1be2265d Cr-Commit-Position: refs/heads/master@{#29835} https://codereview.chromium.org/1254723005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Revert of Revert "In RegExp, lastIndex is read with ToLength, not ToInteger" (issue 1254723005 by machenb...@chromium.org)

2015-07-24 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1254723005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1254723005/1 https://codereview.chromium.org/1254723005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro