[v8-dev] Re: Rewrite the function that converts timestamp to year, month and day in C++. (issue811006)

LGTM with a couple of nits. http://codereview.chromium.org/811006/diff/14001/15003 File src/runtime.cc (right): http://codereview.chromium.org/811006/diff/14001/15003#newcode5080 src/runtime.cc:5080: static const int day_from_month[] = {0, 31, 59, 90, 120, 151, Let's change these constants to f

[v8-dev] Re: Rewrite the function that converts timestamp to year, month and day in C++. (issue811006)

http://codereview.chromium.org/811006/diff/8001/9003 File src/runtime.cc (right): http://codereview.chromium.org/811006/diff/8001/9003#newcode5150 src/runtime.cc:5150: class YearMonthDate { On 2010/03/11 13:48:53, Mads Ager wrote: Instead of having a class that does all the work in it's constru

[v8-dev] Re: Rewrite the function that converts timestamp to year, month and day in C++. (issue811006)

http://codereview.chromium.org/811006/diff/8001/9003 File src/runtime.cc (right): http://codereview.chromium.org/811006/diff/8001/9003#newcode5150 src/runtime.cc:5150: class YearMonthDate { Instead of having a class that does all the work in it's constructor, can't you have a static method that