Committed patchset #2 manually as r21766 (presubmit successful).
https://codereview.chromium.org/298823008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/06/11 09:44:25, Sven Panne wrote:
Committed patchset #2 manually as r21766 (presubmit successful).
huh? I thought this CL has been dismissed after Weiliang's last comment.
https://codereview.chromium.org/298823008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
On 2014/06/11 10:49:28, Yang wrote:
On 2014/06/11 09:44:25, Sven Panne wrote:
Committed patchset #2 manually as r21766 (presubmit successful).
huh? I thought this CL has been dismissed after Weiliang's last comment.
Hmmm, reading it again, it seems that this CL was really not necessary.
I'm fine reverting it
https://codereview.chromium.org/298823008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
lgtm
https://codereview.chromium.org/298823008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/05/23 09:18:03, Weiliang wrote:
Friendly ping.
It is not a specific fix for x87 port, but for overall ia32.
https://codereview.chromium.org/298823008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
lgtm, although IIRC we have already removed any explicit checks for sahf
support
in the ia32 backend when generating code, so I don't think this change has
any
effect. However, it does seem to make sense for consistency.
Please fix the indentation nit and I will land this for you.
On 2014/05/28 08:17:47, danno wrote:
lgtm, although IIRC we have already removed any explicit checks for sahf
support
in the ia32 backend when generating code, so I don't think this change
has
any
effect. However, it does seem to make sense for consistency.
Please fix the indentation
