[v8-dev] Re: ShiftAmountsAllowReplaceByRotate Extension (issue 24095002)

2013-09-17 Thread bangfu . tao
On 2013/09/17 05:58:31, Sven Panne wrote: On 2013/09/16 14:54:24, Bangfu wrote: > On 2013/09/16 13:51:48, Sven Panne wrote: > > Committed patchset #2 manually as r16735. > > for example: > > var b = 0x1234; > function rol(num, cnt) > { > return (num << cnt) | (num >>> (32 - cnt)); > } > var c;

[v8-dev] Re: ShiftAmountsAllowReplaceByRotate Extension (issue 24095002)

2013-09-16 Thread svenpanne
On 2013/09/16 14:54:24, Bangfu wrote: On 2013/09/16 13:51:48, Sven Panne wrote: > Committed patchset #2 manually as r16735. for example: var b = 0x1234; function rol(num, cnt) { return (num << cnt) | (num >>> (32 - cnt)); } var c; for(var i = 0; i < 1000; i++) { c = rol(b, 30); } I

[v8-dev] Re: ShiftAmountsAllowReplaceByRotate Extension (issue 24095002)

2013-09-16 Thread bangfu . tao
On 2013/09/16 13:51:48, Sven Panne wrote: Committed patchset #2 manually as r16735. for example: var b = 0x1234; function rol(num, cnt) { return (num << cnt) | (num >>> (32 - cnt)); } var c; for(var i = 0; i < 1000; i++) { c = rol(b, 30); } In the above example, V8 compiler would replace

[v8-dev] Re: ShiftAmountsAllowReplaceByRotate Extension (issue 24095002)

2013-09-16 Thread svenpanne
Committed patchset #2 manually as r16735. https://codereview.chromium.org/24095002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gro

[v8-dev] Re: ShiftAmountsAllowReplaceByRotate Extension (issue 24095002)

2013-09-16 Thread svenpanne
LGTM, although it would be nice to know if there is some real-world example which benefits from this or if there is some follow-up CL building on this. Landing this for you... https://codereview.chromium.org/24095002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/gr

[v8-dev] Re: ShiftAmountsAllowReplaceByRotate Extension (issue 24095002)

2013-09-16 Thread bangfu . tao
Reviewers: Benedikt Meurer, Sven Panne, Message: On 2013/09/13 12:54:49, Sven Panne wrote: Can we have an explicit test case for this? test case added, thank you for review. Description: In the case of shift amounts with two constants and if their sum is equal 32, then shift can also be re