[v8-dev] Re: Simplified CPU/CpuFeatures a bit. (issue 258993002)

2014-04-30 Thread svenpanne
https://codereview.chromium.org/258993002/diff/1/src/arm/assembler-arm.cc File src/arm/assembler-arm.cc (left): https://codereview.chromium.org/258993002/diff/1/src/arm/assembler-arm.cc#oldcode137 src/arm/assembler-arm.cc:137: PrintFeatures(); On 2014/04/29 15:25:17, vincent.belliard.arm wrote:

[v8-dev] Re: Simplified CPU/CpuFeatures a bit. (issue 258993002)

2014-04-29 Thread svenpanne
On 2014/04/28 16:27:50, m.m.capewell wrote: On 2014/04/28 08:18:53, Sven Panne wrote: Committed patchset #1 manually as r21001 (presubmit successful). I think this breaks ARM64 non-simulator builds, as at least test/cctest/test-assembler-arm64.cc uses CPU::Setup(). Hmmm, I am totally

[v8-dev] Re: Simplified CPU/CpuFeatures a bit. (issue 258993002)

2014-04-29 Thread m . m . capewell
On 2014/04/29 06:26:54, Sven Panne wrote: On 2014/04/28 16:27:50, m.m.capewell wrote: On 2014/04/28 08:18:53, Sven Panne wrote: Committed patchset #1 manually as r21001 (presubmit successful). I think this breaks ARM64 non-simulator builds, as at least test/cctest/test-assembler-arm64.cc

[v8-dev] Re: Simplified CPU/CpuFeatures a bit. (issue 258993002)

2014-04-29 Thread m . m . capewell
On 2014/04/29 09:24:17, m.m.capewell wrote: On 2014/04/29 06:26:54, Sven Panne wrote: On 2014/04/28 16:27:50, m.m.capewell wrote: On 2014/04/28 08:18:53, Sven Panne wrote: Committed patchset #1 manually as r21001 (presubmit successful). I think this breaks ARM64 non-simulator builds,

[v8-dev] Re: Simplified CPU/CpuFeatures a bit. (issue 258993002)

2014-04-29 Thread ulan
On 2014/04/29 09:42:40, m.m.capewell wrote: On 2014/04/29 09:24:17, m.m.capewell wrote: On 2014/04/29 06:26:54, Sven Panne wrote: On 2014/04/28 16:27:50, m.m.capewell wrote: On 2014/04/28 08:18:53, Sven Panne wrote: Committed patchset #1 manually as r21001 (presubmit successful).

[v8-dev] Re: Simplified CPU/CpuFeatures a bit. (issue 258993002)

2014-04-28 Thread bmeurer
lgtm https://codereview.chromium.org/258993002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from it,

[v8-dev] Re: Simplified CPU/CpuFeatures a bit. (issue 258993002)

2014-04-28 Thread svenpanne
Committed patchset #1 manually as r21001 (presubmit successful). https://codereview.chromium.org/258993002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Simplified CPU/CpuFeatures a bit. (issue 258993002)

2014-04-28 Thread m . m . capewell
On 2014/04/28 08:18:53, Sven Panne wrote: Committed patchset #1 manually as r21001 (presubmit successful). I think this breaks ARM64 non-simulator builds, as at least test/cctest/test-assembler-arm64.cc uses CPU::Setup(). https://codereview.chromium.org/258993002/ -- -- v8-dev mailing list