[v8-dev] Re: Simplify string copy in SubStringStub. (issue 326943002)

2014-06-11 Thread yangguo
Committed patchset #2 manually as r21756 (presubmit successful). https://codereview.chromium.org/326943002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To

[v8-dev] Re: Simplify string copy in SubStringStub. (issue 326943002)

2014-06-10 Thread bmeurer
LGTM with comment https://codereview.chromium.org/326943002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving

[v8-dev] Re: Simplify string copy in SubStringStub. (issue 326943002)

2014-06-10 Thread bmeurer
https://codereview.chromium.org/326943002/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): https://codereview.chromium.org/326943002/diff/1/src/arm/code-stubs-arm.cc#newcode3329 src/arm/code-stubs-arm.cc:3329: Register scratch1, We need only one scratch register now,