[v8-dev] Re: Snapshot i18n Javascript code (issue 23304005)

2013-08-23 Thread jochen
Committed patchset #2 manually as r16298 (presubmit successful). https://codereview.chromium.org/23304005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Snapshot i18n Javascript code (issue 23304005)

2013-08-20 Thread mstarzinger
On 2013/08/20 09:51:26, jochen wrote: https://codereview.chromium.org/23304005/diff/1/src/i18n.js File src/i18n.js (right): https://codereview.chromium.org/23304005/diff/1/src/i18n.js#newcode29 src/i18n.js:29: // ECMAScript 402 API implementation is broken into separate files for On 2013/08

[v8-dev] Re: Snapshot i18n Javascript code (issue 23304005)

2013-08-20 Thread jochen
https://codereview.chromium.org/23304005/diff/1/src/i18n.js File src/i18n.js (right): https://codereview.chromium.org/23304005/diff/1/src/i18n.js#newcode29 src/i18n.js:29: // ECMAScript 402 API implementation is broken into separate files for On 2013/08/20 09:49:29, Michael Starzinger wrote: Th

[v8-dev] Re: Snapshot i18n Javascript code (issue 23304005)

2013-08-20 Thread mstarzinger
LGTM. https://codereview.chromium.org/23304005/diff/1/src/i18n.js File src/i18n.js (right): https://codereview.chromium.org/23304005/diff/1/src/i18n.js#newcode29 src/i18n.js:29: // ECMAScript 402 API implementation is broken into separate files for This file is rubber-stamped under the assumpti