A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/724083003/ by vogelh...@chromium.org.
The reason for reverting is: Build bots break due to memory leak..
https://codereview.chromium.org/724023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
Committed patchset #2 (id:20001) manually as
eafce666f49f13011849b6c0c40b271676ec91cf (presubmit successful).
https://codereview.chromium.org/724023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
lgtm
https://codereview.chromium.org/724023002/diff/20001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/724023002/diff/20001/test/cctest/test-api.cc#newcode24223
test/cctest/test-api.cc:24223: CHECK(cached_data->rejected);
Maybe there should als
On 2014/11/13 13:04:19, Yang wrote:
On 2014/11/13 13:03:01, vogelheim wrote:
> https://codereview.chromium.org/724023002/diff/1/src/api.cc
> File src/api.cc (right):
>
> https://codereview.chromium.org/724023002/diff/1/src/api.cc#newcode1759
> src/api.cc:1759: source->cached_data->rejected = (scr
On 2014/11/13 13:03:01, vogelheim wrote:
https://codereview.chromium.org/724023002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/724023002/diff/1/src/api.cc#newcode1759
src/api.cc:1759: source->cached_data->rejected = (script_data == NULL);
If ScriptData is the "in
https://codereview.chromium.org/724023002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/724023002/diff/1/src/api.cc#newcode1759
src/api.cc:1759: source->cached_data->rejected = (script_data == NULL);
If ScriptData is the "internal" structure (vs CachedData as an "API
https://codereview.chromium.org/724023002/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/724023002/diff/1/src/api.cc#newcode1759
src/api.cc:1759: source->cached_data->rejected = (script_data == NULL);
I find this a bit weird...
- I expected ..->rejected to be set at
