Committed patchset #3 manually as r21934 (presubmit successful).
https://codereview.chromium.org/304223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc#newcode2874
src/mark-compact.cc:2874: // We special case ConstantPoolArrays below
since they could contain
contain contain
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc#newcode2876
src/mark-compact.cc:2876: if (!(compacting_
dst-IsConstantPoolArray())) {
On 2014/06/03 22:57:11, Michael
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc#newcode2874
src/mark-compact.cc:2874: // We special case ConstantPoolArrays below
since they could contain
On 2014/06/04
lgtm
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc#newcode2876
src/mark-compact.cc:2876: if (!(compacting_
dst-IsConstantPoolArray())) {
On 2014/06/04 10:15:56,
https://codereview.chromium.org/304223002/diff/40001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/304223002/diff/40001/src/mark-compact.cc#newcode2859
src/mark-compact.cc:2859: } else if (dst-IsConstantPoolArray()) {
On 2014/06/04 10:54:16, Hannes Payer
On 2014/05/29 15:54:12, rmcilroy wrote:
Given that ConstantPoolArrays can contain raw int32 or int64 values, I
think
this change is necessary to ensure we don't confuse a raw int value as a
tagged
pointer when migrating a ConstantPoolArray. PTAL.
Ping? Could you take a look please
LGTM (clenching teeth) to fix the bug, but this special casing is getting
out of
hand and the code needs to be restructured soon.
https://codereview.chromium.org/304223002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
+Hannes, I would like him to also sign off on this.
https://codereview.chromium.org/304223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
