Drive-by with a question.
https://chromiumcodereview.appspot.com/88013002/diff/20001/include/v8.h
File include/v8.h (left):
https://chromiumcodereview.appspot.com/88013002/diff/20001/include/v8.h#oldcode386
include/v8.h:386: templateclass M
Is this change backward-compatible? It seems that
https://chromiumcodereview.appspot.com/88013002/diff/20001/include/v8.h
File include/v8.h (left):
https://chromiumcodereview.appspot.com/88013002/diff/20001/include/v8.h#oldcode386
include/v8.h:386: templateclass M
On 2013/12/20 11:47:51, Paweł Hajdan Jr. wrote:
Is this change
LGTM, but (as discussed offline) please add a warning comment that the
actual
class hierarchy might be changed/simplified in the future.
https://codereview.chromium.org/88013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Committed patchset #2 manually as r18093 (presubmit successful).
https://codereview.chromium.org/88013002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2013/11/26 11:28:43, dcarney wrote:
ptal
the UniquePersistent code is taken from
https://code.google.com/p/chromium/codesearch#chromium/src/base/memory/scoped_ptr.hq=scoped_ptrsq=package:chromiumtype=cs
we may need a few extra features such as swap() and PassAs() to be able to
replace
