https://codereview.chromium.org/345903004/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/345903004/diff/1/BUILD.gn#newcode1067
BUILD.gn:1067: source_set("v8_libplatform") {
yes, external targets can depend on this
https://codereview.chromium.org/345903004/diff/1/BUILD.gn
https://codereview.chromium.org/345903004/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/345903004/diff/1/BUILD.gn#newcode1067
BUILD.gn:1067: source_set("v8_libplatform") {
Does this needs visibility?
visibility = ":*" # Only targets in this file can depend on this.
v8
Committed patchset #1 manually as r22180 (presubmit successful).
https://codereview.chromium.org/345903004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/345903004/diff/1/samples/process.cc
File samples/process.cc (right):
https://codereview.chromium.org/345903004/diff/1/samples/process.cc#newcode650
samples/process.cc:650: v8::V8::InitializePlatform(platform);
On 2014/07/02 07:37:52, Jakob wrote:
Is it intentiona
LGTM.
https://codereview.chromium.org/345903004/diff/1/samples/process.cc
File samples/process.cc (right):
https://codereview.chromium.org/345903004/diff/1/samples/process.cc#newcode650
samples/process.cc:650: v8::V8::InitializePlatform(platform);
Is it intentional that this platform is never s
