[v8-dev] Re: Start adding support for elements to the LookupIterator (issue 1144883002 by verwa...@chromium.org)

2015-05-21 Thread 'I haz the power ' via codereview.chromium.org
Patchset 6 (id:??) landed as https://crrev.com/16484824b65b6fc4e57c45dd4e055213021fb705 Cr-Commit-Position: refs/heads/master@{#28546} https://codereview.chromium.org/1144883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Start adding support for elements to the LookupIterator (issue 1144883002 by verwa...@chromium.org)

2015-05-21 Thread commit-bot
Committed patchset #6 (id:90001) https://codereview.chromium.org/1144883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Start adding support for elements to the LookupIterator (issue 1144883002 by verwa...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144883002/90001 https://codereview.chromium.org/1144883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Start adding support for elements to the LookupIterator (issue 1144883002 by verwa...@chromium.org)

2015-05-21 Thread commit-bot
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/593) v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile

[v8-dev] Re: Start adding support for elements to the LookupIterator (issue 1144883002 by verwa...@chromium.org)

2015-05-21 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144883002/70001 https://codereview.chromium.org/1144883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Start adding support for elements to the LookupIterator (issue 1144883002 by verwa...@chromium.org)

2015-05-20 Thread commit-bot
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/2715) https://codereview.chromium.org/1144883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.googl

[v8-dev] Re: Start adding support for elements to the LookupIterator (issue 1144883002 by verwa...@chromium.org)

2015-05-20 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1144883002/50001 https://codereview.chromium.org/1144883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Start adding support for elements to the LookupIterator (issue 1144883002 by verwa...@chromium.org)

2015-05-19 Thread verwaest
Addressed comments https://codereview.chromium.org/1144883002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: Start adding support for elements to the LookupIterator (issue 1144883002 by verwa...@chromium.org)

2015-05-19 Thread jkummerow
LGTM with a nit. https://codereview.chromium.org/1144883002/diff/10006/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/1144883002/diff/10006/src/elements.cc#newcode1531 src/elements.cc:1531: static uint32_t GetIndexForKeyImpl(FixedArrayBase* store, uint32_t index)