[v8-dev] Re: Start removing deprecated APIs from cctest (issue 1333463002 by joc...@chromium.org)

2015-09-07 Thread jochen
ptal https://codereview.chromium.org/1333463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Start removing deprecated APIs from cctest (issue 1333463002 by joc...@chromium.org)

2015-09-07 Thread vogelheim
lgtm https://codereview.chromium.org/1333463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: Start removing deprecated APIs from cctest (issue 1333463002 by joc...@chromium.org)

2015-09-07 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/c161799f2cfb3229d38adf7e98475add68cc94fc Cr-Commit-Position: refs/heads/master@{#30622} https://codereview.chromium.org/1333463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Start removing deprecated APIs from cctest (issue 1333463002 by joc...@chromium.org)

2015-09-07 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1333463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Start removing deprecated APIs from cctest (issue 1333463002 by joc...@chromium.org)

2015-09-07 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333463002/20001 https://codereview.chromium.org/1333463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Start removing deprecated APIs from cctest (issue 1333463002 by joc...@chromium.org)

2015-09-07 Thread rmcilroy
lgtm with an optional suggestion. Thanks! https://codereview.chromium.org/1333463002/diff/1/test/cctest/cctest.h File test/cctest/cctest.h (right): https://codereview.chromium.org/1333463002/diff/1/test/cctest/cctest.h#newcode452 test/cctest/cctest.h:452: return v8::Local(); nit - could you