[v8-dev] Re: Stores to external references don't need write barriers. (issue 21357003)

Committed patchset #2 manually as r15989 (presubmit successful). https://codereview.chromium.org/21357003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Stores to external references don't need write barriers. (issue 21357003)

https://codereview.chromium.org/21357003/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/21357003/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode4345 src/ia32/lithium-codegen-ia32.cc:4345: ASSERT(!instr->hydrogen()->NeedsWrit

[v8-dev] Re: Stores to external references don't need write barriers. (issue 21357003)

LGTM with a nit. https://codereview.chromium.org/21357003/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/21357003/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode4345 src/ia32/lithium-codegen-ia32.cc:4345: ASSERT(!instr->hyd

[v8-dev] Re: Stores to external references don't need write barriers. (issue 21357003)

A couple of nits, then lgtm. https://codereview.chromium.org/21357003/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): https://codereview.chromium.org/21357003/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode4345 src/ia32/lithium-codegen-ia32.cc:4345: ASSERT