[v8-dev] Re: StringTable::LookupKey() and all callers handlified. (issue 249103002)

2014-04-23 Thread ishell
Committed patchset #2 manually as r20915 (presubmit successful). https://codereview.chromium.org/249103002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: StringTable::LookupKey() and all callers handlified. (issue 249103002)

2014-04-23 Thread ishell
https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc#newcode2150 src/mark-compact.cc:2150: // String table could have already been marked via handle scope iteration. On 2014/04/

[v8-dev] Re: StringTable::LookupKey() and all callers handlified. (issue 249103002)

2014-04-23 Thread yangguo
LGTM https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): https://codereview.chromium.org/249103002/diff/1/src/mark-compact.cc#newcode2150 src/mark-compact.cc:2150: // String table could have already been marked via handle scope iteration. I wou