LGTM.
http://codereview.chromium.org/316009/diff/7002/7008
File src/arm/fast-codegen-arm.cc (right):
http://codereview.chromium.org/316009/diff/7002/7008#newcode277
Line 277: __ ldr(r0, MemOperand(sp));
On 2009/10/26 12:17:33, fschneider wrote:
> On 2009/10/24 07:30:08, Kevin Millikin wrote:
>
Another round of cleanup:
- Fixes on ARM
- Fixed indentation.
- Removed unnecessary {}-blocks.
- Fixed calls to runtime to restore eax.
- Made comment more consistent.
http://codereview.chromium.org/316009/diff/7002/7008
File src/arm/fast-codegen-arm.cc (right):
http://codereview.chromium.org
I like the cleanup/simplification of ia32 and x64. They look good. I
think the
ARM should be cleaned up in the same way.
There are some coding style comments.
One other comment is that it's probably a good idea to try to make the
comments
the same (where reasonable) on all three platforms.
Added ARM and x64 support.
I did a few changes and cleanup to simplify the rather complicated code.
http://codereview.chromium.org/316009/diff/1001/11
File src/ia32/fast-codegen-ia32.cc (right):
http://codereview.chromium.org/316009/diff/1001/11#newcode247
Line 247: switch (property->kind()
Initial ideas.
http://codereview.chromium.org/316009/diff/1001/11
File src/ia32/fast-codegen-ia32.cc (right):
http://codereview.chromium.org/316009/diff/1001/11#newcode247
Line 247: switch (property->kind()) {
You could avoid duplicating the rather annoying result_saved check.
ObjectLiteral::P
