[v8-dev] Re: Supported folding of constant size allocation followed by dynamic size allocation. (issue 61463005 by ish...@chromium.org)

2014-06-23 Thread ishell
On 2014/01/16 12:58:39, Hannes Payer wrote: Looking good, let's do another performance run. LGTM https://codereview.chromium.org/61463005/diff/610001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/61463005/diff/610001/src/hydrogen-inst

[v8-dev] Re: Supported folding of constant size allocation followed by dynamic size allocation. (issue 61463005)

2014-01-16 Thread hpayer
Looking good, let's do another performance run. LGTM https://codereview.chromium.org/61463005/diff/610001/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/61463005/diff/610001/src/hydrogen-instructions.h#newcode5463 src/hydrogen-instructions.

[v8-dev] Re: Supported folding of constant size allocation followed by dynamic size allocation. (issue 61463005)

2013-12-30 Thread ishell
PTAL at new version. https://codereview.chromium.org/61463005/diff/540001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/61463005/diff/540001/src/hydrogen-instructions.cc#newcode3443 src/hydrogen-instructions.cc:3443: // because otherwise

[v8-dev] Re: Supported folding of constant size allocation followed by dynamic size allocation. (issue 61463005)

2013-12-04 Thread hpayer
https://codereview.chromium.org/61463005/diff/540001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/61463005/diff/540001/src/hydrogen-instructions.cc#newcode3443 src/hydrogen-instructions.cc:3443: // because otherwise it will prevent write

[v8-dev] Re: Supported folding of constant size allocation followed by dynamic size allocation. (issue 61463005)

2013-11-29 Thread hpayer
https://codereview.chromium.org/61463005/diff/540001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/61463005/diff/540001/src/hydrogen-instructions.cc#newcode3445 src/hydrogen-instructions.cc:3445: !wired_allocate_->size()->IsInteger32Const

[v8-dev] Re: Supported folding of constant size allocation followed by dynamic size allocation. (issue 61463005)

2013-11-27 Thread ishell
https://codereview.chromium.org/61463005/diff/20001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/61463005/diff/20001/src/hydrogen-instructions.cc#newcode3390 src/hydrogen-instructions.cc:3390: HInstruction* current_instr = HInstruction::

[v8-dev] Re: Supported folding of constant size allocation followed by dynamic size allocation. (issue 61463005)

2013-11-21 Thread hpayer
https://codereview.chromium.org/61463005/diff/360001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/61463005/diff/360001/src/hydrogen-instructions.cc#newcode3464 src/hydrogen-instructions.cc:3464: if (current_size->IsInteger32Constant()) {

[v8-dev] Re: Supported folding of constant size allocation followed by dynamic size allocation. (issue 61463005)

2013-11-14 Thread mstarzinger
First round of comments. The main comment is about kMaxNonCodeHeapObjectSize. https://codereview.chromium.org/61463005/diff/20001/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/61463005/diff/20001/src/hydrogen-instructions.cc#newcode339

[v8-dev] Re: Supported folding of constant size allocation followed by dynamic size allocation. (issue 61463005)

2013-11-14 Thread mvstanton
Just a few comments, looking good! --Michael https://codereview.chromium.org/61463005/diff/20001/src/hydrogen.cc File src/hydrogen.cc (left): https://codereview.chromium.org/61463005/diff/20001/src/hydrogen.cc#oldcode2482 src/hydrogen.cc:2482: new_object->MakeDoubleAligned(); Why was this remov