[v8-dev] Re: Tentative implementation of string slices (hidden under the flag --string-slices). (issue 7477045)

On 2011/08/26 22:29:05, Vitaly Repeshko wrote: LGTM http://codereview.chromium.org/7477045/diff/62001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7477045/diff/62001/src/arm/code-stubs-arm.cc#newcode5444 src/arm/code-stubs-arm.cc:5444: __

[v8-dev] Re: Tentative implementation of string slices (hidden under the flag --string-slices). (issue 7477045)

LGTM http://codereview.chromium.org/7477045/diff/62001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7477045/diff/62001/src/arm/code-stubs-arm.cc#newcode5444 src/arm/code-stubs-arm.cc:5444: __ nop(0); // Jumping as first instruction would cras

[v8-dev] Re: Tentative implementation of string slices (hidden under the flag --string-slices). (issue 7477045)

LGTM http://codereview.chromium.org/7477045/diff/59001/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/7477045/diff/59001/src/x64/code-stubs-x64.cc#newcode2377 src/x64/code-stubs-x64.cc:2377: __ Set(r14, 0); On 2011/08/26 10:44:40, Yang wrote: O

[v8-dev] Re: Tentative implementation of string slices (hidden under the flag --string-slices). (issue 7477045)

Please take another look. http://codereview.chromium.org/7477045/diff/59001/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7477045/diff/59001/src/ia32/code-stubs-ia32.cc#newcode3415 src/ia32/code-stubs-ia32.cc:3415: __ cmp(Operand(ebx), Imme

[v8-dev] Re: Tentative implementation of string slices (hidden under the flag --string-slices). (issue 7477045)

http://codereview.chromium.org/7477045/diff/59001/src/heap.cc File src/heap.cc (right): http://codereview.chromium.org/7477045/diff/59001/src/heap.cc#newcode2651 src/heap.cc:2651: !ConsString::cast(buffer)->first()->IsSeqString())) || nit: please, indent this line for proper grouping http://cod

[v8-dev] Re: Tentative implementation of string slices (hidden under the flag --string-slices). (issue 7477045)

Thanks Anton. Here's another iteration. Please have a look. http://codereview.chromium.org/7477045/diff/52001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7477045/diff/52001/src/arm/code-stubs-arm.cc#newcode4343 src/arm/code-stubs-arm.cc:4343:

[v8-dev] Re: Tentative implementation of string slices (hidden under the flag --string-slices). (issue 7477045)

http://codereview.chromium.org/7477045/diff/52001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7477045/diff/52001/src/arm/code-stubs-arm.cc#newcode4343 src/arm/code-stubs-arm.cc:4343: __ mov(r9, Operand(0)); does it belong here? maybe move it