[v8-dev] Re: Tracks the usage of executable memory allocated by V8 and exposes the value t... (issue3161015)

On 2010/08/18 09:36:26, Søren Gjesse wrote: Without this change most of the tests crashed during heap teardown. http://codereview.chromium.org/3161015/diff/10002/37005 File src/spaces.cc (right): http://codereview.chromium.org/3161015/diff/10002/37005#newcode2617 src/spaces.cc:2617: Page* p

[v8-dev] Re: Tracks the usage of executable memory allocated by V8 and exposes the value t... (issue3161015)

Without this change most of the tests crashed during heap teardown. http://codereview.chromium.org/3161015/diff/10002/37005 File src/spaces.cc (right): http://codereview.chromium.org/3161015/diff/10002/37005#newcode2617 src/spaces.cc:2617: Page* page = Page::FromAddress(chunk->address()); This

[v8-dev] Re: Tracks the usage of executable memory allocated by V8 and exposes the value t... (issue3161015)

LGTM http://codereview.chromium.org/3161015/diff/10002/37005 File src/spaces.cc (right): http://codereview.chromium.org/3161015/diff/10002/37005#newcode296 src/spaces.cc:296: #if defined(V8_REPORT_EXECUTABLE_MEMORY_USAGE) I don't think we need this conditional compile unless this will have perf