[v8-dev] Re: Turn on d8 interactive debugging before running files passed on the command line (issue 7981023)

2011-09-21 Thread sgjesse
http://codereview.chromium.org/7981023/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1257 src/d8.cc:1257: // Keep using the same context in the interactive shell On 2011/09/21 13:14:49, Kasper Lund wrote: Terminate comment with . Done.

[v8-dev] Re: Turn on d8 interactive debugging before running files passed on the command line (issue 7981023)

2011-09-21 Thread kasperl
http://codereview.chromium.org/7981023/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1261 src/d8.cc:1261: if (i::FLAG_debugger && options.last_run) { options.last_run will be true here, right? http://codereview.chromium.org/7981023/ --

[v8-dev] Re: Turn on d8 interactive debugging before running files passed on the command line (issue 7981023)

2011-09-21 Thread kasperl
Nit: http://codereview.chromium.org/7981023/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1257 src/d8.cc:1257: // Keep using the same context in the interactive shell Terminate comment with . http://codereview.chromium.org/7981023/ --

[v8-dev] Re: Turn on d8 interactive debugging before running files passed on the command line (issue 7981023)

2011-09-21 Thread yangguo
LGTM except for the shared library build. http://codereview.chromium.org/7981023/diff/1/src/d8.cc File src/d8.cc (right): http://codereview.chromium.org/7981023/diff/1/src/d8.cc#newcode1261 src/d8.cc:1261: if (i::FLAG_debugger && options.last_run) { This breaks the shared library build. Putting