On 2010/08/23 12:52:11, Lasse Reichstein wrote:
Is the restriction on having only simple values really necessary, as long
as
you
only expect a shallow copy?
If only a shallow copy is expected, then this restriction does not apply.
When
deep copying is required (as is the case with literals
Is the restriction on having only simple values really necessary, as long
as you
only expect a shallow copy?
I'll upload the changes as a new CL.
http://codereview.chromium.org/3158020/diff/10018/11003
File src/arm/full-codegen-arm.cc (right):
http://codereview.chromium.org/3158020/diff/1001
LGTM.
There's one more requirement to making an array copy-on-write that should be
documented somewhere: its elements must be primitive. AFAIU it is true for
regexp matches which contain either strings or undefined.
http://codereview.chromium.org/3158020/diff/10018/11003
File src/arm/full-codeg
http://codereview.chromium.org/3158020/diff/1/2
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/3158020/diff/1/2#newcode5301
src/arm/codegen-arm.cc:5301: __ ldm(ib, r0, r3.bit() | r4.bit() |
r5.bit() | r6.bit() | r7.bit());
Added check for EmptyFixedArray.
http://codereview.
LGTM with comments.
-- Vitaly
http://codereview.chromium.org/3158020/diff/1/2
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/3158020/diff/1/2#newcode5301
src/arm/codegen-arm.cc:5301: __ ldm(ib, r0, r3.bit() | r4.bit() |
r5.bit() | r6.bit() | r7.bit());
See ia32 comments o
