Committed patchset #1 manually as r16604 (presubmit successful).
https://codereview.chromium.org/23458022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
On 2013/09/09 07:40:39, Sven Panne wrote:
Hmmm, actually I would prefer PAGE_NOACCESS, too. MSDN explicitly
describes
PAGE_GUARD as a mechanism for growable data structures, e.g.
http://msdn.microsoft.com/en-us/library/windows/desktop/aa366549%28v=vs.85%29.aspx.
Therefore I think it is a ter
lgtm
https://codereview.chromium.org/23458022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Hmmm, actually I would prefer PAGE_NOACCESS, too. MSDN explicitly describes
PAGE_GUARD as a mechanism for growable data structures, e.g.
http://msdn.microsoft.com/en-us/library/windows/desktop/aa366549(v=vs.85).aspx.
Therefore I think it is a terrible idea to use this for security, this is
exactly
On 2013/09/06 17:48:46, Cris Neckar wrote:
On 2013/09/05 09:22:12, Michael Starzinger wrote:
> Looking OK from my end. I'll leave the final decision up to Cris.
Yes, the reason we used PAGE_GUARD is so that we would get an actionable
exception in crash reports. This allows us to filter crashes
CC'ing Sven for additional feedback
https://codereview.chromium.org/23458022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
On 2013/09/05 09:22:12, Michael Starzinger wrote:
Looking OK from my end. I'll leave the final decision up to Cris.
Yes, the reason we used PAGE_GUARD is so that we would get an actionable
exception in crash reports. This allows us to filter crashes for
STATUS_GUARD_PAGE_VIOLATION and know with
Looking OK from my end. I'll leave the final decision up to Cris.
https://codereview.chromium.org/23458022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
+cdn
Original OS::Guard was submitted by Cris Neckar. I always assumed that
choice of
PROT_GUARD was intentional.
https://codereview.chromium.org/23458022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are s
