[v8-dev] Re: Use a stub in crankshaft for grow store arrays. (issue 1109333003 by mvstan...@chromium.org)

2015-04-30 Thread commit-bot
Patchset 3 (id:??) landed as https://crrev.com/fb8e6136387339e8089bbf61d4ffee50e4cd957e Cr-Commit-Position: refs/heads/master@{#28163} https://codereview.chromium.org/1109333003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Use a stub in crankshaft for grow store arrays. (issue 1109333003 by mvstan...@chromium.org)

2015-04-30 Thread commit-bot
Committed patchset #3 (id:40001) https://codereview.chromium.org/1109333003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Use a stub in crankshaft for grow store arrays. (issue 1109333003 by mvstan...@chromium.org)

2015-04-30 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1109333003/40001 https://codereview.chromium.org/1109333003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Use a stub in crankshaft for grow store arrays. (issue 1109333003 by mvstan...@chromium.org)

2015-04-30 Thread danno
lgtm https://codereview.chromium.org/1109333003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Use a stub in crankshaft for grow store arrays. (issue 1109333003 by mvstan...@chromium.org)

2015-04-30 Thread mvstanton
Hi Danno, Slight change o' strategy. I'd like to land this CL. The extra work which avoids bailout on large array allocations has issues to debug, and it's not clear that the performance improvement is worthwhile. This CL combined with your follow on to avoid math deopts in Kraken is a good co