[v8-dev] Re: Use atomic operation to read the length of a fixed array. (issue 1034163002 by u...@chromium.org)

2015-04-16 Thread commit-bot
Patchset 3 (id:??) landed as https://crrev.com/aae2c01740364454b807613b8d9d66a33ee45073 Cr-Commit-Position: refs/heads/master@{#27869} https://codereview.chromium.org/1034163002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Use atomic operation to read the length of a fixed array. (issue 1034163002 by u...@chromium.org)

2015-04-16 Thread commit-bot
Committed patchset #3 (id:40001) https://codereview.chromium.org/1034163002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: Use atomic operation to read the length of a fixed array. (issue 1034163002 by u...@chromium.org)

2015-04-16 Thread commit-bot
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1034163002/40001 https://codereview.chromium.org/1034163002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Use atomic operation to read the length of a fixed array. (issue 1034163002 by u...@chromium.org)

2015-03-26 Thread hpayer
lgtm, one nit https://codereview.chromium.org/1034163002/diff/1/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1034163002/diff/1/src/heap/heap.h#newcode748 src/heap/heap.h:748: enum InvocationMode { SWEEPING_IS_OFF, SWEEPING_STARTED }; Can we call it SEQUENTIAL_TO

[v8-dev] Re: Use atomic operation to read the length of a fixed array. (issue 1034163002 by u...@chromium.org)

2015-03-26 Thread ulan
On 2015/03/26 14:39:30, Erik Corry wrote: The description looks wrong. These are synchronized operations, not atomic ones. synchronized_length performs base::Acquire_Load, which is an atomic load. https://codereview.chromium.org/1034163002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: Use atomic operation to read the length of a fixed array. (issue 1034163002 by u...@chromium.org)

2015-03-26 Thread erik . corry
The description looks wrong. These are synchronized operations, not atomic ones. https://codereview.chromium.org/1034163002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v