[v8-dev] Re: Use optparse in js2c.py for python compatibility (issue 1192973004 by b...@strongloop.com)

2015-06-22 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/44bc918458481d60b08d5566f0f31a79e39b85d7 Cr-Commit-Position: refs/heads/master@{#29186} https://codereview.chromium.org/1192973004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Use optparse in js2c.py for python compatibility (issue 1192973004 by b...@strongloop.com)

2015-06-22 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1192973004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Use optparse in js2c.py for python compatibility (issue 1192973004 by b...@strongloop.com)

2015-06-22 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192973004/1 https://codereview.chromium.org/1192973004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Use optparse in js2c.py for python compatibility (issue 1192973004 by b...@strongloop.com)

2015-06-22 Thread yangguo
On 2015/06/22 07:10:08, Michael Achenbach wrote: lgtm +yang lgtm. https://codereview.chromium.org/1192973004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" grou

[v8-dev] Re: Use optparse in js2c.py for python compatibility (issue 1192973004 by b...@strongloop.com)

2015-06-22 Thread machenbach
lgtm +yang https://codereview.chromium.org/1192973004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: Use optparse in js2c.py for python compatibility (issue 1192973004 by b...@strongloop.com)

2015-06-19 Thread info
For background: https://github.com/nodejs/io.js/pull/2022 I realize compatibility with older systems isn't a big issue for Google, but it is for io.js and node.js. https://codereview.chromium.org/1192973004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-

[v8-dev] Re: Use optparse in js2c.py for python compatibility (issue 1192973004 by b...@strongloop.com)

2015-06-19 Thread domenic
The reason we switched to argparse is because optparse doesn't allow nargs="*" options (see https://github.com/v8/v8-git-mirror/commit/8a89a4a5ceeb58303cd9bc2d3e8d362742d59c96). However, as of https://github.com/v8/v8-git-mirror/commit/c93aff4ac63ad9ffb6318e750335208de32b7902 we no longer need t