[v8-dev] Re: Use registers to pass arguments to GenericBinaryOpStub.... (issue554062)

http://codereview.chromium.org/554062/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/554062/diff/1/2#newcode744 src/ia32/codegen-ia32.cc:744: enum ArgLocation { It seems like this should be a member of FloatingPointHelper. http://codereview.chromium.org/554062/di

[v8-dev] Re: Use registers to pass arguments to GenericBinaryOpStub.... (issue554062)

http://codereview.chromium.org/554062/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/554062/diff/1/2#newcode7506 src/ia32/codegen-ia32.cc:7506: HasArgumentsReversed() ? On 2010/01/25 15:44:03, Mads Ager wrote: Indent by one more space. Looks like 3-space indent i

[v8-dev] Re: Use registers to pass arguments to GenericBinaryOpStub.... (issue554062)

LGTM http://codereview.chromium.org/554062/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/554062/diff/1/2#newcode7506 src/ia32/codegen-ia32.cc:7506: HasArgumentsReversed() ? Indent by one more space. Looks like 3-space indent instead of 4-space indent? http://co