[v8-dev] Re: WIP: Parser: delay string internalization. (issue 231073002)

2014-06-03 Thread marja
(Marking comments done here. I'll create a new CL as this is moving away from the WIP state...) https://codereview.chromium.org/231073002/diff/880002/src/ast.h File src/ast.h (right): https://codereview.chromium.org/231073002/diff/880002/src/ast.h#newcode852 src/ast.h:852: ForStatement(Zone*

[v8-dev] Re: WIP: Parser: delay string internalization. (issue 231073002)

2014-06-03 Thread marja
and closing this one; the new CL is https://codereview.chromium.org/314603004 https://codereview.chromium.org/231073002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups

[v8-dev] Re: WIP: Parser: delay string internalization. (issue 231073002)

2014-05-21 Thread ulan
https://codereview.chromium.org/231073002/diff/920001/src/parser-symbol-table.cc File src/parser-symbol-table.cc (right): https://codereview.chromium.org/231073002/diff/920001/src/parser-symbol-table.cc#newcode57 src/parser-symbol-table.cc:57: if (string1-hash != string2-hash) return false; I

[v8-dev] Re: WIP: Parser: delay string internalization. (issue 231073002)

2014-05-21 Thread marja
Reviewers: rossberg, ulan, https://codereview.chromium.org/231073002/diff/920001/src/parser-symbol-table.cc File src/parser-symbol-table.cc (right): https://codereview.chromium.org/231073002/diff/920001/src/parser-symbol-table.cc#newcode57 src/parser-symbol-table.cc:57: if (string1-hash !=

[v8-dev] Re: WIP: Parser: delay string internalization. (issue 231073002)

2014-05-21 Thread marja
Err, s/hash functions/hash values/. https://codereview.chromium.org/231073002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and