On 2009/05/07 07:59:15, Lasse Reichstein wrote:
> Review please.
Are you sure that "%p" doesn't also print "0x" on Linux? I've just
checked that under gcc 4.0.3 it does.
The inconsitency between Windows and Linux behavior on interpreting %p
was the main reason of using "%x" which works everywher
On 2009/05/07 08:25:43, Mikhail Naganov wrote:
> Are you sure that "%p" doesn't also print "0x" on Linux? I've just
checked that
> under gcc 4.0.3 it does.
Not sure at all.
> The inconsitency between Windows and Linux behavior on interpreting %p
was the
> main reason of using "%x" which works e
On 2009/05/07 08:47:02, Lasse Reichstein wrote:
> On 2009/05/07 08:25:43, Mikhail Naganov wrote:
> > Are you sure that "%p" doesn't also print "0x" on Linux? I've just
checked
> that
> > under gcc 4.0.3 it does.
> Not sure at all.
> >
> > The inconsitency between Windows and Linux behavior on in
On 2009/05/07 09:14:42, Søren Gjesse wrote:
> On 2009/05/07 08:47:02, Lasse Reichstein wrote:
> > On 2009/05/07 08:25:43, Mikhail Naganov wrote:
> > > Are you sure that "%p" doesn't also print "0x" on Linux? I've just
checked
> > that
> > > under gcc 4.0.3 it does.
> >
> > Not sure at all.
> >
> >
http://codereview.chromium.org/114010/diff/2002/2003
File src/globals.h (right):
http://codereview.chromium.org/114010/diff/2002/2003#newcode89
Line 89: #define V8PRIp V8_PTR_PREFIX "x"
why not #define V8_PTR_FORMAT "0x%llx"
etc. for all the cases, then
printf("My pointer: "V8_PTR_FORMAT
http://codereview.chromium.org/114010/diff/2002/2003
File src/globals.h (right):
http://codereview.chromium.org/114010/diff/2002/2003#newcode89
Line 89: #define V8PRIp V8_PTR_PREFIX "x"
Certainly prefix is the wrong name; since it goes after the '%' it must
be a suffix.
http://codereview.chromi
The V8_POINTER_PREFIX is a prefix to the "x". It could be dropped entirely,
since we only have one type of pointer display, but this way we can also
define a V8PRId as the prefix followed by "d" to print pointers as decimal.
The "%" is not included in the format to use the same strategy as the
PRI-
