LGTM, with comments. I can make the changes, if you want. It looks
like the test result changes for x64 were mainly made in an earlier
changelist.
http://codereview.chromium.org/155346/diff/1/3
File src/x64/disasm-x64.cc (right):
http://codereview.chromium.org/155346/diff/1/3#newcode509
Line
On Tue, Jul 14, 2009 at 11:09 AM, wrote:
> LGTM, with comments. I can make the changes, if you want. It looks
> like the test result changes for x64 were mainly made in an earlier
> changelist.
Hey Bill,
If you take care of this CL that would be great! I only have single
comment: Why is the t
Codereview.chromium.org won't let me log in, so I'll give the comments by
mail only.
On Tue, Jul 14, 2009 at 11:09, wrote:
> LGTM, with comments. I can make the changes, if you want. It looks
> like the test result changes for x64 were mainly made in an earlier
> changelist.
Yes, this just f
Committed as change http://codereview.chromium.org/149608
Line 509: size left as is.
Line 622: op_size changed to immediate_size
Line 732: Suggested change made.
n 2009/07/14 09:09:22, William Hesse wrote:
> LGTM, with comments. I can make the changes, if you want. It looks
like the
> test
