[v8-dev] Re: X64 Crankshaft: Added some functions needed for delta-blue. (issue6262013)

2011-01-25 Thread whesse
LGTM. http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc#newcode1486 src/x64/lithium-codegen-x64.cc:1486: ASSERT(!argument->IsDoubleRegister()); Do

[v8-dev] Re: X64 Crankshaft: Added some functions needed for delta-blue. (issue6262013)

2011-01-25 Thread lrn
http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc File src/x64/lithium-codegen-x64.cc (right): http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc#newcode1486 src/x64/lithium-codegen-x64.cc:1486: ASSERT(!argument->IsDoubleRegister()); I don't t

[v8-dev] Re: X64 Crankshaft: Added some functions needed for delta-blue. (issue6262013)

2011-01-25 Thread William Hesse
Exactly. But on x64 we can only make operands from stack slots, and registers or xmm registers from the right thing. So exactly. On Tue, Jan 25, 2011 at 3:01 PM, wrote: > > > http://codereview.chromium.org/6262013/diff/1/src/x64/lithium-codegen-x64.cc > File src/x64/lithium-codegen-x64.cc (righ

[v8-dev] Re: X64 Crankshaft: Added some functions needed for delta-blue. (issue6262013)

2011-01-25 Thread Lasse R.H. Nielsen
Yes, so we can't have a DoubleRegister, since ia32 can't make an Operand from an XMM register. /L On Tue, Jan 25, 2011 at 15:21, William Hesse wrote: > Exactly. But on x64 we can only make operands from stack slots, and > registers or xmm registers from the right thing. > So exactly. > > > On T