[v8-dev] Re: X64 Implementation: Implement Generate_Function(Call,Apply)

2009-06-29 Thread whesse
Includes changelist from issue 151004 because 151004 was on a machine that cannot commit. http://codereview.chromium.org/151004 http://codereview.chromium.org/147205/diff/1/2 File src/x64/builtins-x64.cc (right): http://codereview.chromium.org/147205/diff/1/2#newcode185 Line 185: // +1 ~ return

[v8-dev] Re: X64 Implementation: Implement Generate_Function(Call,Apply)

2009-06-28 Thread lrn
LGTM http://codereview.chromium.org/147205/diff/1/2 File src/x64/builtins-x64.cc (right): http://codereview.chromium.org/147205/diff/1/2#newcode185 Line 185: // +1 ~ return address. Not understood. The +1 is added because of the return address? Make a constant and refer to the stack structure.