[v8-dev] Re: d8 workers: make sure Shell::Quit is only called once (issue 1230403003 by bi...@chromium.org)

A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1235083004/ by bi...@chromium.org. The reason for reverting is: Breaks webkit_unit_tests. See http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/853/steps/webkit_unit_tests/logs/st

[v8-dev] Re: d8 workers: make sure Shell::Quit is only called once (issue 1230403003 by bi...@chromium.org)

Committed patchset #5 (id:80001) https://codereview.chromium.org/1230403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: d8 workers: make sure Shell::Quit is only called once (issue 1230403003 by bi...@chromium.org)

Patchset 5 (id:??) landed as https://crrev.com/76184292b392d107609f21662a949b58bb1e258c Cr-Commit-Position: refs/heads/master@{#29654} https://codereview.chromium.org/1230403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: d8 workers: make sure Shell::Quit is only called once (issue 1230403003 by bi...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230403003/80001 https://codereview.chromium.org/1230403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: d8 workers: make sure Shell::Quit is only called once (issue 1230403003 by bi...@chromium.org)

Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/2892) https://codereview.chromium.org/1230403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com htt

[v8-dev] Re: d8 workers: make sure Shell::Quit is only called once (issue 1230403003 by bi...@chromium.org)

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1230403003/60001 https://codereview.chromium.org/1230403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: d8 workers: make sure Shell::Quit is only called once (issue 1230403003 by bi...@chromium.org)

On 2015/07/14 at 04:54:00, jarin wrote: lgtm. Even though it might be better to put the 'once' variable on the Shell class (the Chrome build likes to complain about static initialization). Should be OK: OnceType is an alias for AtomicWord. That being said, if it had a constructor it woul

[v8-dev] Re: d8 workers: make sure Shell::Quit is only called once (issue 1230403003 by bi...@chromium.org)

lgtm https://codereview.chromium.org/1230403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: d8 workers: make sure Shell::Quit is only called once (issue 1230403003 by bi...@chromium.org)

lgtm. Even though it might be better to put the 'once' variable on the Shell class (the Chrome build likes to complain about static initialization). https://codereview.chromium.org/1230403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You recei