On Mon, Dec 1, 2014 at 10:37 AM, wrote:
> I'll address other comments in a separate CL.
>
> On 2014/12/01 15:14:07, arv wrote:
>
>> I thought the design we agreed upon was to allow statements and
>> expressions
>>
> that
>
>> did not reference `this`?
>>
>
> I can change this to work in that fas
I'll address other comments in a separate CL.
On 2014/12/01 15:14:07, arv wrote:
I thought the design we agreed upon was to allow statements and
expressions
that
did not reference `this`?
I can change this to work in that fashion now that I am back.
The proper design would be to use a TD
I thought the design we agreed upon was to allow statements and expressions
that
did not reference `this`?
I can change this to work in that fashion now that I am back.
https://codereview.chromium.org/73003/diff/20001/src/ast-this-access-visitor.cc
File src/ast-this-access-visitor.cc (rig
Committed patchset #2 (id:20001)
https://codereview.chromium.org/73003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/73003/20001
https://codereview.chromium.org/73003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Comments addressed, landing
https://codereview.chromium.org/73003/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/73003/diff/1/src/compiler.cc#newcode792
src/compiler.cc:792: Statement* stmt = body->at(super_call_index);
On 2014/11/27 19:04:40, rossb
LGTM with comments
https://codereview.chromium.org/73003/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/73003/diff/1/src/compiler.cc#newcode792
src/compiler.cc:792: Statement* stmt = body->at(super_call_index);
Perhaps add
CHECK(super_call_index <
