[v8-dev] Re: linux: extend the ifdefs in shell.cc to cover V8_SHARED too (issue7076030)

2011-05-29 Thread ager
LGTM http://codereview.chromium.org/7076030/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: linux: extend the ifdefs in shell.cc to cover V8_SHARED too (issue7076030)

2011-05-27 Thread evan
ping? http://codereview.chromium.org/7076030/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: linux: extend the ifdefs in shell.cc to cover V8_SHARED too (issue7076030)

2011-05-26 Thread evan
On 2011/05/26 23:34:16, rvargas wrote: I think it would be nice to unify the macros across OSes at some point. (and or course, my lgtm is pointless here) Your LGTM is useful in the sense that you might have htoughts on whether the change is correct. :) I will wait for a v8 master to land i

[v8-dev] Re: linux: extend the ifdefs in shell.cc to cover V8_SHARED too (issue7076030)

2011-05-26 Thread rvargas
I think it would be nice to unify the macros across OSes at some point. (and or course, my lgtm is pointless here) http://codereview.chromium.org/7076030/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev