https://codereview.chromium.org/794583002/diff/1/build/features.gypi
File build/features.gypi (left):
https://codereview.chromium.org/794583002/diff/1/build/features.gypi#oldcode100
build/features.gypi:100: }],
This needs to still be here since we want to define
V8_USE_EXTERNAL_STARTUP_DATA
LGTM if you address Ross' comment (i.e. undo half of the patch).
https://codereview.chromium.org/794583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Done. I left a comment in features.gypi - should I put the same comment in
standalone.gypi ?
https://codereview.chromium.org/794583002/diff/1/build/features.gypi
File build/features.gypi (left):
https://codereview.chromium.org/794583002/diff/1/build/features.gypi#oldcode100
Nope, we don't need a duplicate comment. Instead, drop the duplicate
condition.
Btw, if you fully specify the bug (BUG=chromium:421063), then bugdroid can
automatically update the bug with the commit information. AFAIK that doesn't
work when you leave out the chromium: part.
https://codereview.chromium.org/794583002/diff/20001/build/standalone.gypi
File build/standalone.gypi (right):
https://codereview.chromium.org/794583002/diff/20001/build/standalone.gypi#newcode456
build/standalone.gypi:456: ['v8_use_external_startup_data==1', {
On 2014/12/11 14:07:41, Jakob
lgtm
https://codereview.chromium.org/794583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Thanks- can you please land this for me? (IIRC v8 doesn't have a commit
queue.)
https://codereview.chromium.org/794583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/794583002/40001
https://codereview.chromium.org/794583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Committed patchset #3 (id:40001)
https://codereview.chromium.org/794583002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
